diff --git a/app/controllers/api/attachments_controller.rb b/app/controllers/api/attachments_controller.rb index 7d13d704..fc17a9b1 100644 --- a/app/controllers/api/attachments_controller.rb +++ b/app/controllers/api/attachments_controller.rb @@ -5,7 +5,7 @@ module Api skip_before_action :authenticate_user! def create - submitter = Submitter.find_by!(slug: params[:submitter_slug]) unless current_account + submitter = Submitter.find_by!(slug: params[:submitter_slug]) blob = ActiveStorage::Blob.find_signed(params[:blob_signed_id]) diff --git a/app/controllers/submissions_controller.rb b/app/controllers/submissions_controller.rb index d785410b..c4143fb8 100644 --- a/app/controllers/submissions_controller.rb +++ b/app/controllers/submissions_controller.rb @@ -60,7 +60,7 @@ class SubmissionsController < ApplicationController submissions_params[:submission].to_h.map do |_, attrs| submission = @template.submissions.new - attrs[:submitters].each do |_, submitter_attrs| + attrs[:submitters].each do |submitter_attrs| submission.submitters.new(**submitter_attrs, sent_at: params[:send_email] == '1' ? Time.current : nil) end @@ -69,7 +69,7 @@ class SubmissionsController < ApplicationController end def submissions_params - params.permit(submission: { submitters: %i[uuid email] }) + params.permit(submission: { submitters: [%i[uuid email]] }) end def load_template diff --git a/app/controllers/submissions_debug_controller.rb b/app/controllers/submissions_debug_controller.rb index 1970e448..87147e08 100644 --- a/app/controllers/submissions_debug_controller.rb +++ b/app/controllers/submissions_debug_controller.rb @@ -12,10 +12,10 @@ class SubmissionsDebugController < ApplicationController respond_to do |f| f.html do - render 'submit_template/show' + render 'submit_form/show' end f.pdf do - Submissions::GenerateResultAttachments.call(@submitter.submission) + Submissions::GenerateResultAttachments.call(@submitter) send_data ActiveStorage::Attachment.where(name: :documents).last.download, filename: 'debug.pdf', diff --git a/app/javascript/elements/dynamic_list.js b/app/javascript/elements/dynamic_list.js index 82980d45..57c9ccf1 100644 --- a/app/javascript/elements/dynamic_list.js +++ b/app/javascript/elements/dynamic_list.js @@ -4,7 +4,7 @@ import { targets, targetable } from '@github/catalyst/lib/targetable' export default actionable(targetable(class extends HTMLElement { static [targets.static] = ['items'] - addItem = (e) => { + addItem (e) { e.preventDefault() const originalItem = this.items[0] @@ -26,8 +26,9 @@ export default actionable(targetable(class extends HTMLElement { originalItem.parentNode.append(duplicateItem) } - removeItem = (e) => { + removeItem (e) { e.preventDefault() + this.items.find((item) => item.contains(e.target))?.remove() } })) diff --git a/app/javascript/submission_form/area.vue b/app/javascript/submission_form/area.vue index 0c5b536d..dc209e53 100644 --- a/app/javascript/submission_form/area.vue +++ b/app/javascript/submission_form/area.vue @@ -46,7 +46,7 @@ >
- @@ -98,14 +97,13 @@