CP-11289 - Rubocop fixes

app/models/completed_document.rb

@@ -22,10 +22,10 @@ class CompletedDocument < ApplicationRecord
 
   has_one :completed_submitter, primary_key: :submitter_id, inverse_of: :completed_documents, dependent: :destroy
 
-  enum storage_location: {
+  enum :storage_location, {
     legacy: 'legacy',        # Fallback for development/testing
     secured: 'secured'       # Default secured storage (shared with ATS)
-  }, _suffix: true
+  }, suffix: true
 
   # Check if document uses secured storage (default for new documents)
   def uses_secured_storage?

app/services/document_security_service.rb

@@ -27,8 +27,8 @@ class DocumentSecurityService
 
     def cloudfront_configured?
       cloudfront_base_url.present? &&
-      cloudfront_key_pair_id.present? &&
-      cloudfront_private_key.present?
+        cloudfront_key_pair_id.present? &&
+        cloudfront_private_key.present?
     end
 
     def cloudfront_signer
@@ -55,7 +55,7 @@ class DocumentSecurityService
     end
 
     def cloudfront_private_key
-      @cloudfront_private_key ||= ENV['SECURE_ATTACHMENT_PRIVATE_KEY']
+      @cloudfront_private_key ||= ENV.fetch('SECURE_ATTACHMENT_PRIVATE_KEY', nil)
     end
   end
 end

config/initializers/secure_attachment.rb

@@ -10,7 +10,7 @@ if key_secret.present?
     client = Aws::SecretsManager::Client.new
     response = client.get_secret_value(secret_id: key_secret)
     ENV['SECURE_ATTACHMENT_PRIVATE_KEY'] = response.secret_string
-    Rails.logger.info("Successfully loaded CloudFront private key from Secrets Manager")
+    Rails.logger.info('Successfully loaded CloudFront private key from Secrets Manager')
   rescue StandardError => e
     Rails.logger.error("Failed to load CloudFront private key: #{e.message}")
   end

lib/submissions/generate_result_attachments.rb

@@ -847,10 +847,16 @@ module Submissions
 
     def determine_storage_service
       # Use secured storage by default unless explicitly disabled
-      return Rails.application.config.active_storage.service if Rails.env.development? && ENV['DOCUSEAL_DISABLE_SECURED_STORAGE'].present?
+      if Rails.env.development? && ENV['DOCUSEAL_DISABLE_SECURED_STORAGE'].present?
+        return Rails.application.config.active_storage.service
+      end
 
       # Use secured storage if compliance configuration is present
-      Rails.configuration.x.compliance_storage.present? ? 'aws_s3_secured' : Rails.application.config.active_storage.service
+      if Rails.configuration.x.compliance_storage.present?
+        'aws_s3_secured'
+      else
+        Rails.application.config.active_storage.service
+      end
     end
 
     def create_secured_blob(io, filename, service_name)