fix completed submissions scope query

2 years ago · 2d24eac4a3
parent 14c3c8181b
commit 2d24eac4a3
1 changed files with 1 additions and 1 deletions
--- a/app/models/submission.rb
+++ b/app/models/submission.rb
@ -49,7 +49,7 @@ class Submission < ApplicationRecord

  scope :active, -> { where(deleted_at: nil) }
  scope :pending, -> { joins(:submitters).where(submitters: { completed_at: nil }).distinct }
-  scope :completed, -> { left_joins(:submitters).where.not(submitters: { completed_at: nil }).distinct }
+  scope :completed, -> { where.not(id: pending.select(:submission_id)) }

  enum :source, {
    invite: 'invite',