From 3f87d0336d152a1e1164bfcd36382355f7fede0d Mon Sep 17 00:00:00 2001 From: Pete Matsyburka Date: Fri, 8 Nov 2024 13:02:32 +0200 Subject: [PATCH] do not use same reply to as to --- app/mailers/submitter_mailer.rb | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app/mailers/submitter_mailer.rb b/app/mailers/submitter_mailer.rb index 35770150..ad41ee5d 100644 --- a/app/mailers/submitter_mailer.rb +++ b/app/mailers/submitter_mailer.rb @@ -138,9 +138,11 @@ class SubmitterMailer < ApplicationMailer private def build_submitter_reply_to(submitter) - reply_to = - submitter.preferences['reply_to'].presence || - (submitter.submission.created_by_user || submitter.template.author)&.friendly_name&.sub(/\+\w+@/, '@') + reply_to = submitter.preferences['reply_to'].presence + + if reply_to.blank? && (submitter.submission.created_by_user || submitter.template.author)&.email != submitter.email + reply_to = (submitter.submission.created_by_user || submitter.template.author)&.friendly_name&.sub(/\+\w+@/, '@') + end return nil if reply_to.to_s.match?(NO_REPLY_REGEXP)