From 4f013ca927bc4881cf4d707ebe6e8dc91ed8d8f7 Mon Sep 17 00:00:00 2001 From: Pete Matsyburka Date: Fri, 12 Dec 2025 20:34:53 +0200 Subject: [PATCH] do not combine with verification --- app/views/submissions/show.html.erb | 2 +- lib/submitters.rb | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/app/views/submissions/show.html.erb b/app/views/submissions/show.html.erb index bb1d709f..5ecd9ad9 100644 --- a/app/views/submissions/show.html.erb +++ b/app/views/submissions/show.html.erb @@ -4,7 +4,7 @@ <% font_scale = 1040.0 / PdfUtils::US_LETTER_W %> <% configs = AccountConfig.where(account_id: @submission.account_id, key: [AccountConfig::COMBINE_PDF_RESULT_KEY, AccountConfig::WITH_SIGNATURE_ID, AccountConfig::WITH_SUBMITTER_TIMEZONE_KEY, AccountConfig::WITH_SIGNATURE_ID_REASON_KEY]) %> <% with_signature_id = configs.find { |e| e.key == AccountConfig::WITH_SIGNATURE_ID }&.value == true %> -<% is_combined_enabled = configs.find { |e| e.key == AccountConfig::COMBINE_PDF_RESULT_KEY }&.value == true %> +<% is_combined_enabled = configs.find { |e| e.key == AccountConfig::COMBINE_PDF_RESULT_KEY }&.value == true && !@submission.template_fields&.any? { |f| f['type'] == 'verification' } %> <% with_submitter_timezone = configs.find { |e| e.key == AccountConfig::WITH_SUBMITTER_TIMEZONE_KEY }&.value == true %> <% with_signature_id_reason = configs.find { |e| e.key == AccountConfig::WITH_SIGNATURE_ID_REASON_KEY }&.value != false %>
diff --git a/lib/submitters.rb b/lib/submitters.rb index 4d91bf53..c557dd3e 100644 --- a/lib/submitters.rb +++ b/lib/submitters.rb @@ -106,7 +106,8 @@ module Submitters if AccountConfig.exists?(account_id: submitter.submission.account_id, key: AccountConfig::COMBINE_PDF_RESULT_KEY, value: true) && - submitter.submission.submitters.all?(&:completed_at?) + submitter.submission.submitters.all?(&:completed_at?) && + submitter.submission.template_fields.none? { |f| f['type'] == 'verification' } return [submitter.submission.combined_document_attachment || Submissions::EnsureCombinedGenerated.call(submitter)] end