From 4faa0dcd6b680bd85ecd7cc91bdb17f4446cca48 Mon Sep 17 00:00:00 2001 From: Wabo Date: Tue, 2 Jun 2026 15:14:21 -0400 Subject: [PATCH] Shorten pending test reasons for Rubocop compliance --- spec/system/feature_toggles_spec.rb | 4 ++-- spec/system/signing_flow_edge_cases_spec.rb | 6 +++--- spec/system/template_crud_edge_cases_spec.rb | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/spec/system/feature_toggles_spec.rb b/spec/system/feature_toggles_spec.rb index dff474b7..dee48168 100644 --- a/spec/system/feature_toggles_spec.rb +++ b/spec/system/feature_toggles_spec.rb @@ -94,7 +94,7 @@ RSpec.describe 'Feature Toggles' do email: 'second@example.com') end - pending 'blocks the second signer when enabled: Vue component timing issue with Submitters.current_submitter_order?' do + pending 'blocks second signer: Vue timing issue with Submitters.current_submitter_order?' do create(:account_config, account:, key: AccountConfig::ENFORCE_SIGNING_ORDER_KEY, value: true) visit submit_form_path(slug: second_submitter.slug) @@ -143,7 +143,7 @@ RSpec.describe 'Feature Toggles' do let(:other_account) { create(:account) } let(:other_user) { create(:user, account: other_account) } - pending 'does not affect users who already have MFA configured: MFA setup requires multitenant mode' do + pending 'force MFA: requires multitenant mode' do create(:account_config, account: other_account, key: AccountConfig::FORCE_MFA, value: true) sign_in(other_user) diff --git a/spec/system/signing_flow_edge_cases_spec.rb b/spec/system/signing_flow_edge_cases_spec.rb index 0af4d109..b2567a34 100644 --- a/spec/system/signing_flow_edge_cases_spec.rb +++ b/spec/system/signing_flow_edge_cases_spec.rb @@ -20,7 +20,7 @@ RSpec.describe 'Signing Flow Edge Cases' do email: 'second@example.com') end - pending 'prevents the second signer from filling before the first is done: Vue component timing issue with Submitters.current_submitter_order?' do + pending 'blocks second signer: Vue timing issue with Submitters.current_submitter_order?' do create(:account_config, account:, key: AccountConfig::ENFORCE_SIGNING_ORDER_KEY, value: true) visit submit_form_path(slug: second_submitter.slug) @@ -78,7 +78,7 @@ RSpec.describe 'Signing Flow Edge Cases' do create(:account_config, account:, key: AccountConfig::ALLOW_TO_RESUBMIT, value: true) end - pending 'allows a submitter to resubmit after completing: Field not found on second visit to start form' do + pending 'resubmit flow: field not found on second start form visit' do visit start_form_path(slug: template.slug) fill_in 'Email', with: 'john@example.com' @@ -116,7 +116,7 @@ RSpec.describe 'Signing Flow Edge Cases' do submission.update!(template_fields: fields) end - pending 'completes with the header complete button without filling any fields: Vue teleport timing issue with complete button rendering' do + pending 'optional fields: Vue teleport timing issue with complete button' do visit submit_form_path(slug: submitter.slug) find('#expand_form_button').click diff --git a/spec/system/template_crud_edge_cases_spec.rb b/spec/system/template_crud_edge_cases_spec.rb index 89f2d3b6..fb51fc47 100644 --- a/spec/system/template_crud_edge_cases_spec.rb +++ b/spec/system/template_crud_edge_cases_spec.rb @@ -23,7 +23,7 @@ RSpec.describe 'Template CRUD Edge Cases' do expect(template.reload.archived_at).to be_nil end - pending 'lists archived templates on the dedicated index page: Restore button selector not matching' do + pending 'archived templates index: restore button selector not matching' do visit templates_archived_index_path expect(page).to have_content(template.name)