From 626b3ca09df24370f34b973ad97e11c8d770196a Mon Sep 17 00:00:00 2001 From: Ryan Arakawa Date: Wed, 13 Aug 2025 10:12:48 -0500 Subject: [PATCH] fix brakeman and erb lint violations --- .../submitters_request_changes_controller.rb | 2 +- app/views/submissions/show.html.erb | 4 ++-- .../request_changes.html.erb | 10 +++++----- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/app/controllers/submitters_request_changes_controller.rb b/app/controllers/submitters_request_changes_controller.rb index da39fc28..b18d8ed0 100644 --- a/app/controllers/submitters_request_changes_controller.rb +++ b/app/controllers/submitters_request_changes_controller.rb @@ -5,7 +5,7 @@ class SubmittersRequestChangesController < ApplicationController skip_before_action :verify_authenticity_token, only: :request_changes def request_changes - if request.get? + if request.get? || request.head? render 'submitters_request_changes/request_changes', layout: false if request.xhr? else return redirect_back(fallback_location: root_path, alert: 'Invalid request') unless can_request_changes? diff --git a/app/views/submissions/show.html.erb b/app/views/submissions/show.html.erb index f0f74f01..7e878842 100644 --- a/app/views/submissions/show.html.erb +++ b/app/views/submissions/show.html.erb @@ -238,8 +238,8 @@ <% if signed_in? && submitter && submitter.completed_at? && !submitter.declined_at? && !submitter.changes_requested_at? && current_user == @submission.created_by_user %>
<%= link_to 'Request Changes', request_changes_submitter_path(submitter.slug), - class: 'btn btn-sm btn-warning w-full', - data: { turbo_frame: :modal } %> + class: 'btn btn-sm btn-warning w-full', + data: { turbo_frame: :modal } %>
<% end %> diff --git a/app/views/submitters_request_changes/request_changes.html.erb b/app/views/submitters_request_changes/request_changes.html.erb index ed8fb4c1..29fb2cf8 100644 --- a/app/views/submitters_request_changes/request_changes.html.erb +++ b/app/views/submitters_request_changes/request_changes.html.erb @@ -15,11 +15,11 @@ Message (required) <%= f.text_area :reason, - required: true, - class: 'textarea textarea-bordered w-full', - dir: 'auto', - placeholder: 'Please provide specific details about what needs to be changed...', - rows: '6' %> + required: true, + class: 'textarea textarea-bordered w-full', + dir: 'auto', + placeholder: 'Please provide specific details about what needs to be changed...', + rows: '6' %>