From 7a75a6c88787a16106d53a17bd7950efd614978f Mon Sep 17 00:00:00 2001 From: Pete Matsyburka Date: Mon, 2 Nov 2026 09:48:37 +0200 Subject: [PATCH] optimize query --- app/controllers/send_submission_email_controller.rb | 2 +- app/controllers/start_form_controller.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/controllers/send_submission_email_controller.rb b/app/controllers/send_submission_email_controller.rb index 13bd5f161..5cb82a034 100644 --- a/app/controllers/send_submission_email_controller.rb +++ b/app/controllers/send_submission_email_controller.rb @@ -14,7 +14,7 @@ class SendSubmissionEmailController < ApplicationController template = Template.find_by!(slug: params[:template_slug]) @submitter = - Submitter.completed.where(submission: template.submissions).find_by(email: params[:email].to_s.downcase) + Submitter.completed.where(template_id: template.id).find_by(email: params[:email].to_s.downcase) elsif params[:submission_slug] submission = Submission.find_by!(slug: params[:submission_slug]) diff --git a/app/controllers/start_form_controller.rb b/app/controllers/start_form_controller.rb index 7227bd93a..530b3b7be 100644 --- a/app/controllers/start_form_controller.rb +++ b/app/controllers/start_form_controller.rb @@ -80,7 +80,7 @@ class StartFormController < ApplicationController raise ActionController::RoutingError, I18n.t('not_found') if required_params.any? { |_, v| v.blank? } || required_params.except('name').compact_blank.blank? - @submitter = Submitter.where(submission: @template.submissions) + @submitter = Submitter.where(template_id: @template.id) .where.not(completed_at: nil) .find_by!(required_params.except('name')) end