diff --git a/app/controllers/api/submitters_controller.rb b/app/controllers/api/submitters_controller.rb index 313f84fc1..a547ba75a 100644 --- a/app/controllers/api/submitters_controller.rb +++ b/app/controllers/api/submitters_controller.rb @@ -179,10 +179,7 @@ module Api submitters = submitters.where(external_id: params[:external_id]) if params[:external_id].present? submitters = submitters.where(slug: params[:slug]) if params[:slug].present? submitters = submitters.where(submission_id: params[:submission_id]) if params[:submission_id].present? - - if params[:template_id].present? - submitters = submitters.joins(:submission).where(submissions: { template_id: params[:template_id] }) - end + submitters = submitters.where(template_id: params[:template_id]) if params[:template_id].present? maybe_filter_by_completed_at(submitters, params) end diff --git a/lib/submitters/start_form.rb b/lib/submitters/start_form.rb index 6e3781040..3c2ac777d 100644 --- a/lib/submitters/start_form.rb +++ b/lib/submitters/start_form.rb @@ -65,6 +65,7 @@ module Submitters submissions = submissions.where(source:) if source Submitter + .where(template_id: template.id) .where(submission: submissions) .order(id: :desc) .where(declined_at: nil)