diff --git a/app/controllers/api/submissions_controller.rb b/app/controllers/api/submissions_controller.rb index 11e9b3e7..7c00f0f3 100644 --- a/app/controllers/api/submissions_controller.rb +++ b/app/controllers/api/submissions_controller.rb @@ -112,7 +112,9 @@ module Api submissions = submissions.where(slug: params[:slug]) if params[:slug].present? if params[:template_folder].present? - submissions = submissions.joins(template: :folder).where(folder: { name: params[:template_folder] }) + folder = TemplateFolder.find_by(name: params[:template_folder], account_id: current_user.account_id) + + submissions = folder ? submissions.joins(:template).where(template: { folder_id: folder.id }) : submissions.none end if params.key?(:archived) diff --git a/app/controllers/send_submission_email_controller.rb b/app/controllers/send_submission_email_controller.rb index ef6ff62b..45852360 100644 --- a/app/controllers/send_submission_email_controller.rb +++ b/app/controllers/send_submission_email_controller.rb @@ -11,11 +11,16 @@ class SendSubmissionEmailController < ApplicationController def create if params[:template_slug] - @submitter = Submitter.completed.joins(submission: :template).find_by!(email: params[:email].to_s.downcase, - template: { slug: params[:template_slug] }) + template = Template.find_by!(slug: params[:template_slug]) + + @submitter = + Submitter.completed.where(submission: template.submissions).find_by!(email: params[:email].to_s.downcase) elsif params[:submission_slug] - @submitter = Submitter.completed.joins(:submission).find_by(email: params[:email].to_s.downcase, - submission: { slug: params[:submission_slug] }) + submission = Submission.find_by(slug: params[:submission_slug]) + + if submission + @submitter = Submitter.completed.find_by(submission: submission, email: params[:email].to_s.downcase) + end return redirect_to submissions_preview_completed_path(params[:submission_slug], status: :error) unless @submitter else @@ -24,14 +29,18 @@ class SendSubmissionEmailController < ApplicationController RateLimit.call("send-email-#{@submitter.id}", limit: 2, ttl: 5.minutes) - unless EmailEvent.exists?(tag: :submitter_documents_copy, email: @submitter.email, emailable: @submitter, - event_type: :send, created_at: SEND_DURATION.ago..Time.current) - SubmitterMailer.documents_copy_email(@submitter, sig: true).deliver_later! - end + SubmitterMailer.documents_copy_email(@submitter, sig: true).deliver_later! unless already_sent?(@submitter) respond_to do |f| f.html { render :success } f.json { head :ok } end end + + private + + def already_sent?(submitter) + EmailEvent.exists?(tag: :submitter_documents_copy, email: submitter.email, emailable: submitter, + event_type: :send, created_at: SEND_DURATION.ago..Time.current) + end end