From cbc6f4497a81fa9d0e89b28a7ec5bbeb30a669af Mon Sep 17 00:00:00 2001 From: Alex Turchyn Date: Sun, 20 Aug 2023 12:42:47 +0300 Subject: [PATCH] add base feature specs --- .rubocop.yml | 7 +- app/controllers/setup_controller.rb | 5 +- .../submission_form/signature_step.vue | 2 + app/models/encrypted_config.rb | 14 +- app/models/user.rb | 7 +- config/environments/test.rb | 6 + config/storage.yml | 5 + lib/action_mailer_configs_interceptor.rb | 2 + lib/load_active_storage_configs.rb | 1 + lib/submitters/submit_values.rb | 2 +- spec/factories/accounts.rb | 9 + spec/factories/encrypted_configs.rb | 7 + spec/factories/submissions.rb | 14 + spec/factories/submitters.rb | 8 + spec/factories/templates.rb | 62 +++++ spec/factories/users.rb | 12 + spec/fixtures/sample-document.pdf | Bin 0 -> 13264 bytes spec/rails_helper.rb | 2 + spec/system/account_settings_spec.rb | 39 +++ spec/system/api_settings_spec.rb | 18 ++ spec/system/dashboard_spec.rb | 55 ++++ spec/system/email_settings_spec.rb | 98 +++++++ spec/system/esign_spec.rb | 20 ++ spec/system/newsletters_spec.rb | 32 +++ spec/system/personalization_spec.rb | 23 ++ spec/system/profile_settings_spec.rb | 59 +++++ spec/system/setup_spec.rb | 88 +++++++ spec/system/storage_settings_spec.rb | 247 ++++++++++++++++++ spec/system/submit_form_spec.rb | 95 +++++++ spec/system/team_settings_spec.rb | 96 +++++++ spec/system/template_spec.rb | 80 ++++++ spec/system/webhook_settings_spec.rb | 31 +++ 32 files changed, 1134 insertions(+), 12 deletions(-) create mode 100644 spec/factories/accounts.rb create mode 100644 spec/factories/encrypted_configs.rb create mode 100644 spec/factories/submissions.rb create mode 100644 spec/factories/submitters.rb create mode 100644 spec/factories/templates.rb create mode 100644 spec/factories/users.rb create mode 100644 spec/fixtures/sample-document.pdf create mode 100644 spec/system/account_settings_spec.rb create mode 100644 spec/system/api_settings_spec.rb create mode 100644 spec/system/dashboard_spec.rb create mode 100644 spec/system/email_settings_spec.rb create mode 100644 spec/system/esign_spec.rb create mode 100644 spec/system/newsletters_spec.rb create mode 100644 spec/system/personalization_spec.rb create mode 100644 spec/system/profile_settings_spec.rb create mode 100644 spec/system/setup_spec.rb create mode 100644 spec/system/storage_settings_spec.rb create mode 100644 spec/system/submit_form_spec.rb create mode 100644 spec/system/team_settings_spec.rb create mode 100644 spec/system/template_spec.rb create mode 100644 spec/system/webhook_settings_spec.rb diff --git a/.rubocop.yml b/.rubocop.yml index a83324d7..2105cfb1 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -53,10 +53,13 @@ RSpec/NestedGroups: Max: 6 RSpec/MultipleExpectations: - Max: 7 + Max: 20 RSpec/ExampleLength: - Max: 15 + Max: 40 + +RSpec/RSpec/MultipleMemoizedHelpers: + Max: 6 Rails/I18nLocaleTexts: Enabled: false diff --git a/app/controllers/setup_controller.rb b/app/controllers/setup_controller.rb index 3c89e34d..ca45ccf9 100644 --- a/app/controllers/setup_controller.rb +++ b/app/controllers/setup_controller.rb @@ -16,16 +16,17 @@ class SetupController < ApplicationController def create @account = Account.new(account_params) @account.timezone = Accounts.normalize_timezone(@account.timezone) - @user = @account.users.new(user_params) + @encrypted_config = EncryptedConfig.new(encrypted_config_params) unless URI.parse(encrypted_config_params[:value].to_s).class.in?([URI::HTTP, URI::HTTPS]) - @encrypted_config = EncryptedConfig.new(encrypted_config_params) @encrypted_config.errors.add(:value, 'should be a valid URL') return render :index, status: :unprocessable_entity end + return render :index, status: :unprocessable_entity unless @account.valid? + if @user.save encrypted_configs = [ { key: EncryptedConfig::APP_URL_KEY, value: encrypted_config_params[:value] }, diff --git a/app/javascript/submission_form/signature_step.vue b/app/javascript/submission_form/signature_step.vue index af749b30..ff2269c5 100644 --- a/app/javascript/submission_form/signature_step.vue +++ b/app/javascript/submission_form/signature_step.vue @@ -10,6 +10,7 @@ data-tip="Type text" >