From eb82d63774de9aa1816784fa30cfc3fd738dc6be Mon Sep 17 00:00:00 2001
From: Wabo <admin@wabo.cc>
Date: Wed, 3 Jun 2026 11:01:29 -0400
Subject: [PATCH] Fix SMS dropdown JS timing and enable switch logic

---
 app/views/sms_settings/index.html.erb | 38 ++++++++++++++++++++-------
 lib/sms.rb                            |  5 ++++
 2 files changed, 34 insertions(+), 9 deletions(-)

diff --git a/app/views/sms_settings/index.html.erb b/app/views/sms_settings/index.html.erb
index 72fecae2..055b1fa6 100644
--- a/app/views/sms_settings/index.html.erb
+++ b/app/views/sms_settings/index.html.erb
@@ -4,6 +4,7 @@
     <h1 class="text-4xl font-bold mb-4">SMS</h1>
 
     <% value = @encrypted_config.value || {} %>
+    <% sms_enabled = Sms.enabled?(current_account) %>
     <% sms_live = Sms.enabled_for?(current_account) %>
     <%
       provider_labels = {
@@ -32,6 +33,16 @@
           </p>
         </div>
       </div>
+    <% elsif sms_enabled %>
+      <div class="alert alert-warning mb-4">
+        <%= svg_icon('discount_check_filled', class: 'w-6 h-6') %>
+        <div>
+          <p class="font-bold">SMS is enabled but not fully configured</p>
+          <p class="text-gray-700">
+            Select a provider below and fill in its credentials, then save.
+          </p>
+        </div>
+      </div>
     <% else %>
       <div class="alert mb-4">
         <%= svg_icon('info_circle', class: 'w-6 h-6') %>
@@ -187,16 +198,25 @@
 
 <script>
 (function() {
-  var select = document.getElementById('sms_provider_select');
-  if (!select) return;
-  function sync() {
-    var v = select.value;
-    document.querySelectorAll('[data-provider-block]').forEach(function(b) {
-      b.classList.toggle('hidden', b.dataset.providerBlock !== v);
-    });
+  function ready(fn) {
+    if (document.readyState !== 'loading') {
+      fn();
+    } else {
+      document.addEventListener('DOMContentLoaded', fn);
+    }
   }
-  select.addEventListener('change', sync);
-  sync();
+  ready(function() {
+    var select = document.getElementById('sms_provider_select');
+    if (!select) return;
+    function sync() {
+      var v = select.value;
+      document.querySelectorAll('[data-provider-block]').forEach(function(b) {
+        b.classList.toggle('hidden', b.dataset.providerBlock !== v);
+      });
+    }
+    select.addEventListener('change', sync);
+    sync();
+  });
 })();
 </script>
 
diff --git a/lib/sms.rb b/lib/sms.rb
index 9a9fe1c7..67a70f11 100644
--- a/lib/sms.rb
+++ b/lib/sms.rb
@@ -20,6 +20,11 @@ module Sms
     record&.value
   end
 
+  def enabled?(account)
+    config = configuration_for(account)
+    config.is_a?(Hash) && !!config['enabled']
+  end
+
   def enabled_for?(account)
     config = configuration_for(account)
     return false unless config.is_a?(Hash)