From b9cad1ddc11d84425124cfa0603409fcd71e435f Mon Sep 17 00:00:00 2001 From: Simon Jackson Date: Thu, 2 Apr 2026 10:03:52 +0100 Subject: [PATCH] fix(ci): build RDPWrapOffsetFinder via .sln to fix resolution RDPWrapOffsetFinder.vcxproj uses \ for both include paths (zydis/include, zydis/dependencies/zycore/include, zydis/msvc) and for the linker's AdditionalDependencies (zydis/msvc/bin/ReleaseX*/Zydis.lib). When msbuild targets the vcxproj directly SolutionDir defaults to the vcxproj's own directory (RDPWrapOffsetFinder/), making all those paths point at a non-existent sibling - hence C1083 on every TU. Fix: build RDPWrapOffsetFinder.sln /t:RDPWrapOffsetFinder so MSBuild sets SolutionDir to the submodule root (src-csharp/RDPOffsetFinder/) where zydis/ actually lives. Zydis.dll is still compiled first via its own standalone vcxproj (which has no SolutionDir dependency). --- .github/workflows/build-and-release.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-and-release.yml b/.github/workflows/build-and-release.yml index 5725d77..4d96560 100644 --- a/.github/workflows/build-and-release.yml +++ b/.github/workflows/build-and-release.yml @@ -112,15 +112,18 @@ jobs: @{ Platform = 'x64'; ZydisCfg = 'Release MD DLL'; ZydisBin = 'ReleaseX64'; Arch = 'x64' } @{ Platform = 'Win32'; ZydisCfg = 'Release MD DLL'; ZydisBin = 'ReleaseX86'; Arch = 'x86' } )) { - # Build Zydis DLL + # Build Zydis DLL directly (standalone vcxproj, no SolutionDir dependency) msbuild src-csharp/RDPOffsetFinder/zydis/msvc/zydis/Zydis.vcxproj ` /p:Configuration="$($cfg.ZydisCfg)" ` /p:Platform="$($cfg.Platform)" ` /p:PlatformToolset=v143 ` /v:minimal - # Build RDPWrapOffsetFinder - msbuild src-csharp/RDPOffsetFinder/RDPWrapOffsetFinder/RDPWrapOffsetFinder.vcxproj ` + # Build RDPWrapOffsetFinder via the .sln so $(SolutionDir) resolves to + # the submodule root where zydis/ lives — the vcxproj AdditionalInclude- + # Directories use $(SolutionDir)\zydis\include and fail if built directly. + msbuild src-csharp/RDPOffsetFinder/RDPWrapOffsetFinder.sln ` + /t:RDPWrapOffsetFinder ` /p:Configuration=Release ` /p:Platform="$($cfg.Platform)" ` /p:PlatformToolset=v143 `