From baa1e38b7dd343652dc02bcf0f4aa6d97fcfcc45 Mon Sep 17 00:00:00 2001
From: Simon Jackson <admin@jacksonfamily.me>
Date: Thu, 2 Apr 2026 21:00:21 +0100
Subject: [PATCH] fix(ci): use 2-digit year for MSI PackageVersion (MSI major
 must be <256)

WiX ICE24 rejects '2026.4.2' because MSI requires major<256 and 2026>255.
Derive msiVer by stripping the century prefix: '2026.4.2' -> '26.4.2'.
The full yyyy.M.d version is still used for release tag names and file names.
---
 .github/workflows/build-and-release.yml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/build-and-release.yml b/.github/workflows/build-and-release.yml
index 253c358..2fdd979 100644
--- a/.github/workflows/build-and-release.yml
+++ b/.github/workflows/build-and-release.yml
@@ -439,7 +439,9 @@ jobs:
       - name: Build MSI packages
         shell: pwsh
         run: |
-          $ver = '${{ steps.build_ver.outputs.version }}'
+          $ver    = '${{ steps.build_ver.outputs.version }}'
+          # MSI ProductVersion requires major<256; strip century: "2026.4.2" -> "26.4.2"
+          $msiVer = $ver.Substring(2)
           foreach ($arch in @('x64', 'x86', 'arm64')) {
             # Stage arch-specific inputs next to the .wixproj
             Copy-Item ".\rdpwrap_$arch.dll"  "msi\rdpwrap_$arch.dll"  -Force
@@ -451,7 +453,7 @@ jobs:
               -c Release `
               /p:Platform=$arch `
               /p:OutputName="RDPWrapper-$arch" `
-              /p:PackageVersion=$ver `
+              /p:PackageVersion=$msiVer `
               /p:OutputPath="$PWD/msi_out/$arch"
             if ($LASTEXITCODE -ne 0) { throw "WiX build failed for $arch" }