sms fail event

app/controllers/submission_events_controller.rb

@@ -12,6 +12,7 @@ class SubmissionEventsController < ApplicationController
     'send_2fa_sms' => '2fa',
     'send_2fa_email' => '2fa',
     'send_sms' => 'send',
+    'fail_sms' => 'alert_circle',
     'phone_verified' => 'phone_check',
     'email_verified' => 'email_check',
     'click_sms' => 'hand_click',

app/models/submission_event.rb

@@ -45,6 +45,7 @@ class SubmissionEvent < ApplicationRecord
     send_email: 'send_email',
     bounce_email: 'bounce_email',
     complaint_email: 'complaint_email',
+    fail_sms: 'fail_sms',
     send_reminder_email: 'send_reminder_email',
     send_sms: 'send_sms',
     send_2fa_sms: 'send_2fa_sms',

app/views/submission_events/index.html.erb

@@ -50,8 +50,11 @@
             <% elsif event.event_type == 'delegate_form' %>
               <% delegate_from = event.data['old_email'].presence || versions.rfind { |v| v.created_at <= event.event_timestamp }&.then { |v| v.name || v.phone } %>
               <%= t('submission_event_names.delegate_form_by_html', from: delegate_from, to: event.data['email']) %>
-            <% elsif event.event_type.include?('send_') %>
+            <% elsif event.event_type.include?('send_') || event.event_type == 'fail_sms' %>
               <%= t("submission_event_names.#{event.event_type}_to_html", submitter_name:) %>
+              <% if event.data['error_code'].present? %>
+                <span class="text-base-content/60">(<%= t('error') %>: <%= event.data['error_code'] %>)</span>
+              <% end %>
             <% elsif event.event_type.start_with?('bounce_') ||  event.event_type.start_with?('complaint_') %>
               <%= t("submission_event_names.#{event.event_type}_html", submitter_name:) %>
             <% else %>

config/locales/i18n.yml

@@ -1046,10 +1046,12 @@ en: &en
     link: Link
     mcp: MCP
     self: Sign Yourself
+  error: Error
   submission_event_names:
     send_email_to_html: '<b>Email sent</b> to %{submitter_name}'
     bounce_email_html: '<b>Email bounced</b> %{submitter_name}'
     complaint_email_html: '<b>Spam complaint</b> %{submitter_name}'
+    fail_sms_to_html: '<b>SMS failed</b> to %{submitter_name}'
     send_reminder_email_to_html: '<b>Reminder email sent</b> to %{submitter_name}'
     send_sms_to_html: '<b>SMS sent</b> to %{submitter_name}'
     send_2fa_sms_to_html: '<b>Verification SMS sent</b> to %{submitter_name}'
@@ -2196,10 +2198,12 @@ es: &es
     link: Enlace
     mcp: MCP
     self: Firma tú mismo
+  error: Error
   submission_event_names:
     send_email_to_html: '<b>Correo electrónico enviado</b> a %{submitter_name}'
     bounce_email_html: '<b>Correo electrónico rebotado</b> %{submitter_name}'
     complaint_email_html: '<b>Queja de spam</b> %{submitter_name}'
+    fail_sms_to_html: '<b>SMS fallido</b> a %{submitter_name}'
     send_reminder_email_to_html: '<b>Correo de recordatorio enviado</b> a %{submitter_name}'
     send_sms_to_html: '<b>SMS enviado</b> a %{submitter_name}'
     send_2fa_sms_to_html: '<b>SMS de verificación enviado</b> a %{submitter_name}'
@@ -3360,10 +3364,12 @@ it: &it
     link: Link
     mcp: MCP
     self: Firma te stesso
+  error: Errore
   submission_event_names:
     send_email_to_html: '<b>Email inviata</b> a %{submitter_name}'
     bounce_email_html: '<b>Email respinta</b> %{submitter_name}'
     complaint_email_html: '<b>Segnalazione spam</b> %{submitter_name}'
+    fail_sms_to_html: '<b>SMS non consegnato</b> a %{submitter_name}'
     send_reminder_email_to_html: '<b>E-mail di promemoria inviata</b> a %{submitter_name}'
     send_sms_to_html: '<b>SMS inviato</b> a %{submitter_name}'
     send_2fa_sms_to_html: '<b>SMS di verifica inviato</b> a %{submitter_name}'
@@ -4507,10 +4513,12 @@ fr: &fr
     link: Lien
     mcp: MCP
     self: Signer vous-même
+  error: Erreur
   submission_event_names:
     send_email_to_html: "<b>E‑mail envoyé</b> à %{submitter_name}"
     bounce_email_html: "<b>E‑mail rejeté</b> %{submitter_name}"
     complaint_email_html: "<b>Plainte spam</b> %{submitter_name}"
+    fail_sms_to_html: "<b>SMS non distribué</b> à %{submitter_name}"
     send_reminder_email_to_html: "<b>E‑mail de rappel envoyé</b> à %{submitter_name}"
     send_sms_to_html: "<b>SMS envoyé</b> à %{submitter_name}"
     send_2fa_sms_to_html: "<b>SMS de vérification envoyé</b> à %{submitter_name}"
@@ -5670,10 +5678,12 @@ pt: &pt
     link: Link
     mcp: MCP
     self: Assine você mesmo
+  error: Erro
   submission_event_names:
     send_email_to_html: '<b>Email enviado</b> para %{submitter_name}'
     bounce_email_html: '<b>Email não entregue</b> %{submitter_name}'
     complaint_email_html: '<b>Reclamação de spam</b> %{submitter_name}'
+    fail_sms_to_html: '<b>SMS não entregue</b> para %{submitter_name}'
     send_reminder_email_to_html: '<b>Email de lembrete enviado</b> para %{submitter_name}'
     send_sms_to_html: '<b>SMS enviado</b> para %{submitter_name}'
     send_2fa_sms_to_html: '<b>SMS de verificação enviado</b> para %{submitter_name}'
@@ -6833,10 +6843,12 @@ de: &de
     link: Link
     mcp: MCP
     self: Selbst unterschreiben
+  error: Fehler
   submission_event_names:
     send_email_to_html: '<b>E-Mail gesendet</b> an %{submitter_name}'
     bounce_email_html: '<b>E-Mail unzustellbar</b> %{submitter_name}'
     complaint_email_html: '<b>Spam-Beschwerde</b> %{submitter_name}'
+    fail_sms_to_html: '<b>SMS unzustellbar</b> an %{submitter_name}'
     send_reminder_email_to_html: '<b>Erinnerungs-E-Mail gesendet</b> an %{submitter_name}'
     send_sms_to_html: '<b>SMS gesendet</b> an %{submitter_name}'
     send_2fa_sms_to_html: '<b>Verifizierungs-SMS gesendet</b> an %{submitter_name}'
@@ -8520,10 +8532,12 @@ nl: &nl
     link: Link
     mcp: MCP
     self: Zelf ondertekenen
+  error: Fout
   submission_event_names:
     send_email_to_html: "<b>E-mail verzonden</b> naar %{submitter_name}"
     bounce_email_html: "<b>E-mail geretourneerd</b> %{submitter_name}"
     complaint_email_html: "<b>Spamklacht</b> %{submitter_name}"
+    fail_sms_to_html: "<b>SMS niet afgeleverd</b> naar %{submitter_name}"
     send_reminder_email_to_html: "<b>Herinneringsmail verzonden</b> naar %{submitter_name}"
     send_sms_to_html: "<b>SMS verzonden</b> naar %{submitter_name}"
     send_2fa_sms_to_html: "<b>Verificatie-SMS verzonden</b> naar %{submitter_name}"

lib/submissions/generate_audit_trail.rb

@@ -469,7 +469,7 @@ module Submissions
       end
 
       events_data = submission.submission_events.sort_by(&:event_timestamp).filter_map do |event|
-        next if event.event_type.in?(%w[bounce_email complaint_email])
+        next if event.event_type.in?(%w[bounce_email complaint_email fail_sms])
 
         submitter = submission.submitters.find { |e| e.id == event.submitter_id }
         versions = submitter_versions_index[submitter.id] || []

lib/submitters/serialize_for_api.rb

@@ -8,6 +8,13 @@ module Submitters
       methods: %i[status application_key]
     }.freeze
 
+    EVENT_DATA_KEYS = {
+      'decline_form' => %w[reason],
+      'complete_verification' => %w[firstname lastname method country idcode],
+      'fail_kba' => %w[issues],
+      'fail_sms' => %w[status error_code]
+    }.freeze
+
     module_function
 
     def call(submitter, with_template: false, with_events: false, with_documents: true, with_urls: false,
@@ -55,7 +62,7 @@ module Submitters
     def serialize_events(events)
       events.map do |event|
         event.as_json(only: %i[id submitter_id event_type event_timestamp])
-             .merge('data' => event.data.slice('reason', 'firstname', 'lastname', 'method', 'country', 'idcode'))
+             .merge('data' => event.data.slice(*EVENT_DATA_KEYS[event.event_type]))
       end
     end
   end