CP-11565 - Code review changes

app/controllers/api/submitters_controller.rb

@@ -41,7 +41,7 @@ module Api
       old_values = @submitter.values.dup
 
       assign_submitter_attrs(@submitter, normalized_params)
-      save_submitter_and_track_changes(normalized_params, new_attachments, old_values)
+      save_submitter_and_track_changes(new_attachments, old_values)
       handle_post_save_actions(normalized_params)
 
       render json: Submitters::SerializeForApi.call(@submitter, with_template: false, with_urls: true,
@@ -161,7 +161,7 @@ module Api
       [normalized_params, new_attachments]
     end
 
-    def save_submitter_and_track_changes(_normalized_params, new_attachments, old_values)
+    def save_submitter_and_track_changes(new_attachments, old_values)
       ApplicationRecord.transaction do
         Submissions::NormalizeParamUtils.save_default_value_attachments!(new_attachments, [@submitter])
 

lib/send_webhook_request.rb

@@ -29,7 +29,7 @@ module SendWebhookRequest
       req.headers['User-Agent'] = USER_AGENT
 
       # Send webhook secret headers from the configured secret hash
-      webhook_url.secret.each do |header_name, header_value|
+      webhook_url.secret&.each do |header_name, header_value|
         req.headers[header_name] = header_value
       end