allow to remove default value

pull/250/head
Pete Matsyburka 2 years ago
parent dec33b4331
commit a1a920e536

@ -52,7 +52,8 @@ module Submissions
process_fields_param(submitter_attrs[:fields], template_fields, submitter_uuid) process_fields_param(submitter_attrs[:fields], template_fields, submitter_uuid)
end end
if template_fields != submission.template.fields || submitters_attrs.any? { |e| e[:completed].present? } if template_fields != (submission.template_fields || submission.template.fields) ||
submitters_attrs.any? { |e| e[:completed].present? }
submission.template_fields = template_fields submission.template_fields = template_fields
submission.template_schema = submission.template.schema submission.template_schema = submission.template.schema
end end
@ -80,11 +81,15 @@ module Submissions
next if f['type'].in?(%w[signature image initials file]) next if f['type'].in?(%w[signature image initials file])
next if f['submitter_uuid'] != submitter_uuid next if f['submitter_uuid'] != submitter_uuid
value = values[f['uuid']] next unless values.key?(f['uuid'])
next if value.blank? value = values[f['uuid']]
if value.present?
f['default_value'] = value f['default_value'] = value
else
f.delete('default_value')
end
end end
end end
@ -110,8 +115,12 @@ module Submissions
field['readonly'] = attrs['readonly'] if attrs.key?('readonly') field['readonly'] = attrs['readonly'] if attrs.key?('readonly')
field['required'] = attrs['required'] if attrs.key?('required') field['required'] = attrs['required'] if attrs.key?('required')
if attrs['default_value'].present? && !field['type'].in?(%w[signature image initials file]) if attrs.key?('default_value') && !field['type'].in?(%w[signature image initials file])
if attrs['default_value'].present?
field['default_value'] = Submitters::NormalizeValues.normalize_value(field, attrs['default_value']) field['default_value'] = Submitters::NormalizeValues.normalize_value(field, attrs['default_value'])
else
field.delete('default_value')
end
end end
return field if attrs['validation_pattern'].blank? return field if attrs['validation_pattern'].blank?

@ -22,7 +22,7 @@ module Submissions
default_values = submitter_params[:values] || {} default_values = submitter_params[:values] || {}
submitter_params[:fields]&.each do |f| submitter_params[:fields]&.each do |f|
default_values[f[:name]] = f[:default_value] if f[:default_value].present? default_values[f[:name]] = f[:default_value] if f.key?(:default_value)
end end
return submitter_params if default_values.blank? return submitter_params if default_values.blank?

Loading…
Cancel
Save