generate unique uuids for cloned templates

app/controllers/api/templates_clone_controller.rb

@@ -7,23 +7,18 @@ module Api
     def create
       authorize!(:manage, @template)
 
-      template = current_account.templates.new(source: :api)
+      cloned_template = Templates::Clone.call(@template,
+                                              author: current_user,
+                                              name: params[:name],
+                                              application_key: params[:application_key],
+                                              folder_name: params[:folder_name])
 
-      template.application_key = params[:application_key]
+      cloned_template.source = :api
-      template.name = params[:name] || "#{@template.name} (Clone)"
+      cloned_template.save!
-      template.account = @template.account
-      template.author = current_user
-      template.assign_attributes(@template.slice(:folder_id, :fields, :schema, :submitters))
 
-      if params[:folder_name].present?
+      Templates::CloneAttachments.call(template: cloned_template, original_template: @template)
-        template.folder = TemplateFolders.find_or_create_by_name(current_user, params[:folder_name])
-      end
 
-      template.save!
+      render json: cloned_template.as_json(serialize_params)
-
-      Templates::CloneAttachments.call(template:, original_template: @template)
-
-      render json: template.as_json(serialize_params)
     end
 
     private

app/controllers/templates_controller.rb

@@ -42,10 +42,15 @@ class TemplatesController < ApplicationController
   end
 
   def create
-    @template.account = current_account
+    if @base_template
-    @template.author = current_user
+      @template = Templates::Clone.call(@base_template, author: current_user,
-    @template.folder = TemplateFolders.find_or_create_by_name(current_user, params[:folder_name])
+                                                        name: params.dig(:template, :name),
-    @template.assign_attributes(@base_template.slice(:fields, :schema, :submitters)) if @base_template
+                                                        folder_name: params[:folder_name])
+    else
+      @template.account = current_account
+      @template.author = current_user
+      @template.folder = TemplateFolders.find_or_create_by_name(current_user, params[:folder_name])
+    end
 
     if @template.save
       Templates::CloneAttachments.call(template: @template, original_template: @base_template) if @base_template

lib/templates/clone.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+module Templates
+  module Clone
+    module_function
+
+    def call(original_template, author:, application_key: nil, name: nil, folder_name: nil)
+      original_template_account = original_template.account
+
+      template = original_template_account.templates.new
+
+      template.application_key = application_key
+      template.author = author
+      template.name = name || "#{original_template.name} (Clone)"
+
+      template.assign_attributes(original_template.slice(:folder_id, :schema))
+
+      template.folder = TemplateFolders.find_or_create_by_name(author, folder_name) if folder_name.present?
+
+      submitter_uuids_replacements = {}
+
+      cloned_submitters = original_template['submitters'].deep_dup
+      cloned_fields = original_template['fields'].deep_dup
+
+      cloned_submitters.each do |submitter|
+        new_submitter_uuid = SecureRandom.uuid
+
+        submitter_uuids_replacements[submitter['uuid']] = new_submitter_uuid
+        submitter['uuid'] = new_submitter_uuid
+      end
+
+      cloned_fields.each do |field|
+        field['uuid'] = SecureRandom.uuid
+        field['submitter_uuid'] = submitter_uuids_replacements[field['submitter_uuid']]
+      end
+
+      template.assign_attributes(fields: cloned_fields, submitters: cloned_submitters)
+
+      template
+    end
+  end
+end

lib/templates/clone_attachments.rb

@@ -5,23 +5,48 @@ module Templates
     module_function
 
     def call(template:, original_template:)
+      schema_uuids_replacements = {}
+
+      cloned_schema = original_template['schema'].deep_dup
+      cloned_fields = template['fields'].deep_dup
+
+      cloned_schema.each do |schema_item|
+        new_schema_item_uuid = SecureRandom.uuid
+
+        schema_uuids_replacements[schema_item['attachment_uuid']] = new_schema_item_uuid
+        schema_item['attachment_uuid'] = new_schema_item_uuid
+      end
+
+      cloned_fields.each do |field|
+        next if field['areas'].blank?
+
+        field['areas'].each do |area|
+          area['attachment_uuid'] = schema_uuids_replacements[area['attachment_uuid']]
+        end
+      end
+
+      template.update!(schema: cloned_schema, fields: cloned_fields)
+
       original_template.documents.preload(:preview_images_attachments).each do |document|
         new_document = ActiveStorage::Attachment.create!(
-          uuid: document.uuid,
+          uuid: schema_uuids_replacements[document.uuid],
           blob_id: document.blob_id,
           name: 'documents',
           record: template
         )
 
-        ApplicationRecord.no_touching do
+        clone_document_preview_images_attachments(document:, new_document:)
-          document.preview_images_attachments.each do |preview_image|
+      end
-            ActiveStorage::Attachment.create!(
+    end
-              uuid: preview_image.uuid,
+
-              blob_id: preview_image.blob_id,
+    def clone_document_preview_images_attachments(document:, new_document:)
-              name: 'preview_images',
+      ApplicationRecord.no_touching do
-              record: new_document
+        document.preview_images_attachments.each do |preview_image|
-            )
+          ActiveStorage::Attachment.create!(
-          end
+            blob_id: preview_image.blob_id,
+            name: 'preview_images',
+            record: new_document
+          )
         end
       end
     end

spec/factories/template_folders.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+FactoryBot.define do
+  factory :template_folder do
+    account
+
+    author factory: %i[user]
+    name { Faker::Book.title }
+
+    trait :with_templates do
+      after(:create) do |template_folder|
+        create_list(:template, 2, folder: template_folder, account: template_folder.account)
+      end
+    end
+  end
+end

spec/system/template_spec.rb

@@ -74,5 +74,70 @@ RSpec.describe 'Template' do
         expect(page).to have_current_path(edit_template_path(template), ignore_query: true)
       end
     end
+
+    it 'clone a template and move it to a new folder' do
+      click_link 'Clone'
+
+      within '#modal' do
+        fill_in 'template[name]', with: 'New Template Name'
+        click_link 'Change Folder'
+        fill_in 'folder_name', with: 'New Folder Name'
+
+        expect do
+          click_button 'Submit'
+        end.to change { Template.active.count }.by(1).and change { TemplateFolder.active.count }.by(1)
+
+        template = Template.last
+
+        expect(template.name).to eq('New Template Name')
+        expect(template.folder.name).to eq('New Folder Name')
+        expect(page).to have_current_path(edit_template_path(template), ignore_query: true)
+      end
+    end
+
+    it 'clones a template and moves it to an existing folder' do
+      template_folder = create(:template_folder, :with_templates, account:, author: user)
+
+      click_link 'Clone'
+
+      within '#modal' do
+        template_folder.reload
+        fill_in 'template[name]', with: 'New Template Name'
+        click_link 'Change Folder'
+      end
+
+      within '.autocomplete' do
+        find('div', text: template_folder.name).click
+      end
+
+      within '#modal' do
+        expect do
+          click_button 'Submit'
+        end.not_to(change { TemplateFolder.active.count })
+      end
+
+      template = Template.last
+      expect(template.name).to eq('New Template Name')
+      expect(template.folder.name).to eq(template_folder.name)
+      expect(page).to have_current_path(edit_template_path(template), ignore_query: true)
+    end
+
+    it 'moves a template' do
+      find('[data-tip="Move"]', visible: false).hover
+      find('[data-tip="Move"]').click
+
+      within '#modal' do
+        fill_in 'name', with: 'New Folder Name'
+
+        expect do
+          click_button 'Move'
+        end.to change { TemplateFolder.active.count }.by(1)
+
+        template_folder = TemplateFolder.last
+
+        expect(template_folder.name).to eq('New Folder Name')
+        expect(page).to have_current_path(template_path(template), ignore_query: true)
+      end
+    end
   end
 end