mirror of https://github.com/docusealco/docuseal
You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
1.3 KiB
1.3 KiB
Pull Requests
Here are some reasons why a pull request may not be merged:
- It hasn’t been reviewed.
- It doesn’t include specs for new functionality.
- It doesn’t include documentation for new functionality.
- It changes behavior without changing the relevant documentation, comments, or specs.
- It changes behavior of an existing public API, breaking backward compatibility.
- It breaks the tests on a supported platform.
- It doesn’t merge cleanly (requiring Git rebasing and conflict resolution).
If you would like to help in this process, you can start by evaluating open pull requests against the criteria above. For example, if a pull request does not include specs for new functionality, you can add a comment like: “If you would like this feature to be added to Thor, please add specs to ensure that it does not break in the future.” This will help move a pull request closer to being merged.
Include this emoji in the top of your ticket to signal to us that you read this file: 🌈
Specs
Ensure that all specs and code linting checks pass before submitting a pull request.
To execute the specs locally, run:
bundle exec rspec
Linting checks are done with RuboCop. To run the linter, use:
bundle exec rubocop